+ Reply to Thread
Page 3 of 12 FirstFirst 1 2 3 4 5 ... LastLast
Results 21 to 30 of 111
  1. #21
    Quantum Mechanic Lee Mac's Avatar
    Computer Details
    Lee Mac's Computer Details
    Operating System:
    Windows 7 Ultimate (32-bit)
    Discipline
    Multi-disciplinary
    Lee Mac's Discipline Details
    Discipline
    Multi-disciplinary
    Details
    Custom Programming / Software Customisation
    Using
    AutoCAD 2013
    Join Date
    Aug 2008
    Location
    London, England
    Posts
    15,816

    Default

    Registered forum members do not see this ad.

    Nice one Buzzard,

    Bear in mind though that as it stands, the program will still try to execute, even if the load_dialog fails, due to how you have structured the last Cond statement.

    Also, the COND and IF together are redundant when testing the same variable in a few of your functions, as both are conditionals, I would either use one or the other

    Again, just suggestions for improvement.

    Lee
    Lee Mac Programming

    With Mathematics there is the possibility of perfect rigour, so why settle for less?

    Just another Swamper

  2. #22

  3. #23
    Quantum Mechanic Lee Mac's Avatar
    Computer Details
    Lee Mac's Computer Details
    Operating System:
    Windows 7 Ultimate (32-bit)
    Discipline
    Multi-disciplinary
    Lee Mac's Discipline Details
    Discipline
    Multi-disciplinary
    Details
    Custom Programming / Software Customisation
    Using
    AutoCAD 2013
    Join Date
    Aug 2008
    Location
    London, England
    Posts
    15,816

    Default

    Quote Originally Posted by The Buzzard View Post
    I guess I did not fix that correctly?
    Not quite.

    Again, let me re-iterate though, there wasn't too much wrong with your original code, as always, there are many ways to code the same thing, and I wouldn't like you to think that I am nagging you into changing parts of your program, I'm just offering ideas as to how I would approach the coding, I will not be offended if you decide not to incorporate my suggestions
    Lee Mac Programming

    With Mathematics there is the possibility of perfect rigour, so why settle for less?

    Just another Swamper

  4. #24
    Forum Deity
    Using
    AutoCAD 2009
    Join Date
    Oct 2008
    Posts
    2,112

    Default

    I think you are referring to where the conditional has ended?
    I am not quite sure where it is suppose to end.
    At the end of the whole Main Function I think?

  5. #25

  6. #26
    Quantum Mechanic Lee Mac's Avatar
    Computer Details
    Lee Mac's Computer Details
    Operating System:
    Windows 7 Ultimate (32-bit)
    Discipline
    Multi-disciplinary
    Lee Mac's Discipline Details
    Discipline
    Multi-disciplinary
    Details
    Custom Programming / Software Customisation
    Using
    AutoCAD 2013
    Join Date
    Aug 2008
    Location
    London, England
    Posts
    15,816

    Default

    Ok, the Cond is correct now - but do you understand why we are using it in that way? I wouldn't want you to use code just because I recommend it.
    Lee Mac Programming

    With Mathematics there is the possibility of perfect rigour, so why settle for less?

    Just another Swamper

  7. #27
    Forum Deity
    Using
    AutoCAD 2009
    Join Date
    Oct 2008
    Posts
    2,112

    Default

    Now I see what you are saying about the cond & if being redundant.
    I did not know I could combine them, But it makes good sense.

    I have now fixed that.

  8. #28
    Forum Deity
    Using
    AutoCAD 2009
    Join Date
    Oct 2008
    Posts
    2,112

    Default

    Quote Originally Posted by Lee Mac View Post
    Ok, the Cond is correct now - but do you understand why we are using it in that way? I wouldn't want you to use code just because I recommend it.
    The light bulb lit up the last minute. I understand it now as I had to figure it out for myself.
    They share the same variable, so they should be under the same conditional.

    Thanks

  9. #29
    Forum Deity
    Using
    AutoCAD 2009
    Join Date
    Oct 2008
    Posts
    2,112

    Default

    Attention All!

    Version V0.2 has been uploaded to the first post.
    Added Non-Coded Flanged Only Head.

    Enjoy the code.
    The Buzzard

  10. #30
    Quantum Mechanic ReMark's Avatar
    Computer Details
    ReMark's Computer Details
    Operating System:
    Windows 7 Pro 64-bit
    Computer:
    Thinkmate
    Motherboard:
    Intel DX58SO2 LGA1366 X58
    CPU:
    Intel i7-960 Quad-core 3.20GHz 8MB cache
    RAM:
    12GB (3x4GB) PC3-106000 DDR3
    Graphics:
    nVidia Quadro 4000, 2GB GDDR5
    Primary Storage:
    150GB Velocipraptor 10,000 rpm
    Secondary Storage:
    none
    Monitor:
    Dell P24LLH - 24" wide screen LCD
    Discipline
    See details...
    ReMark's Discipline Details
    Occupation
    CAD Draftsman/Designer...chemical manufacturing.
    Discipline
    See details below.
    Details
    I work for a specialty chemical manufacturer. I do a little bit of everything from P&IDs to civil to architectural and structural.
    Using
    AutoCAD 2013
    Join Date
    Nov 2005
    Location
    Norwalk, CT USofA
    Posts
    33,486

    Default

    Registered forum members do not see this ad.

    No fair! You're changing it faster than I can use it! LOL

    Thank you Buzzard. Already shared it with one fellow CAD user and he went crazy with glee!
    "I have only come here seeking knowledge. Things they wouldn't teach me of in college." The Police

    Eat brains...gain more knowledge!

Similar Threads

  1. LISP that will draw pressure vessel heads
    By dbakeg00 in forum AutoLISP, Visual LISP & DCL
    Replies: 8
    Last Post: 18th Jun 2011, 04:35 pm
  2. Dished Heads?
    By DANIEL in forum AutoLISP, Visual LISP & DCL
    Replies: 21
    Last Post: 5th Apr 2010, 02:51 pm
  3. Help fixing a LISP that draws pressure vessels
    By dbakeg00 in forum AutoLISP, Visual LISP & DCL
    Replies: 4
    Last Post: 2nd Mar 2010, 05:30 pm
  4. Lisp for generating Pressure Vessel views?
    By a_differently abled_draft in forum AutoLISP, Visual LISP & DCL
    Replies: 19
    Last Post: 20th Oct 2009, 11:05 am
  5. Tutorials for Pressure Vessel Drawings
    By larawks in forum AutoCAD Beginners' Area
    Replies: 5
    Last Post: 11th Feb 2009, 06:55 pm

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts