Lisp for Revision Box - Need help

[woodman78]

remainder of code

  (start_dialog)
  (unload_dialog dcl_id)
  (if userclick
	(progn
	  (setq edata (entget en))
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L1-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L1-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L1-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L1-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L2-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L2-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L2-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L2-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L3-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L3-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L3-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L3-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L4-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L4-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L4-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L4-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L5-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L5-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L5-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L5-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L6-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L6-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L6-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L6-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L7-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L7-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L7-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L7-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L8-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L8-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L8-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L8-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L9-Reva) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L9-Bya) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L9-Datea) (assoc 1 edata) edata))
	  (entmod el)
	  (setq edata (entget (entnext (dxf -1 edata))))
	  (setq el (subst (cons 1 L9-Descriptiona) (assoc 1 edata) edata))
	  (entmod el)
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
          (command "REGEN")
	);progn
   );if
(princ)
);defun
;;;**********************************************************
(defun dxf (code elist)
  (cdr (assoc code elist))
);defun
;;;**********************************************************
(princ)
;;;**********************************************************
;
;CODING ENDS HERE

;;----------------=={ Set Visibility State }==----------------;;
;;                                                            ;;
;;  Sets the Visibility Parameter of a Dynamic Block          ;;
;;  (if present) to a specific value (if allowed).            ;;
;;------------------------------------------------------------;;
;;  Author: Lee Mac, Copyright © 2011 - www.lee-mac.com       ;;
;;------------------------------------------------------------;;


(defun LM:SetVisibilityState ( block value )
    (
        (lambda ( name value )
            (vl-some
                (function
                    (lambda ( prop )
                        (if
                            (and
                                (eq name (vla-get-propertyname prop))
                                (member value (mapcar 'strcase (vlax-get prop 'allowedvalues)))
                            )
                            (progn
                                (vla-put-value prop
                                    (vlax-make-variant value (vlax-variant-type (vla-get-value prop)))
                                )
                                value
                            )
                        )
                    )
                )
                (vlax-invoke block 'getdynamicblockproperties)
            )
        )
        (LM:GetVisibilityParameterName block) (strcase value)
    )
)

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;-----------=={ Get Visibility Parameter Name }==------------;;
;;                                                            ;;
;;  Returns the name of the Visibility Parameter of a         ;;
;;  Dynamic Block (if present).                               ;;
;;------------------------------------------------------------;;
;;  Author: Lee Mac, Copyright © 2011 - www.lee-mac.com       ;;
;;------------------------------------------------------------;;


(defun LM:GetVisibilityParameterName ( block / visib )  
    (if
        (and
            (vlax-property-available-p block 'effectivename)
            (setq block
                (vla-item
                    (vla-get-blocks (vla-get-document block))
                    (vla-get-effectivename block)
                )
            )
            (eq :vlax-true (vla-get-isdynamicblock block))
            (eq :vlax-true (vla-get-hasextensiondictionary block))
            (setq visib
                (vl-some
                    (function
                        (lambda ( pair )
                            (if
                                (and
                                    (= 360 (car pair))
                                    (eq "BLOCKVISIBILITYPARAMETER" (cdr (assoc 0 (entget (cdr pair)))))
                                )
                                (cdr pair)
                            )
                        )
                    )
                    (dictsearch
                        (vlax-vla-object->ename (vla-getextensiondictionary block))
                        "ACAD_ENHANCEDBLOCK"
                    )
                )
            )
        )
        (cdr (assoc 301 (entget visib)))
    )
)

DCL is below.

[woodman78]

ed1 : edit_box  { edit_limit = 2;  edit_width = 2;}
ed2 : edit_box  { edit_limit = 3;  edit_width = 3;}
ed3 : edit_box  { edit_limit = 10;  edit_width = 9;}
ed4 : edit_box  { edit_limit = 58;  edit_width = 58;}
attab12 : dialog {
 label = "Drawing Title Block";
: boxed_radio_column { 
 label = "Application" ;    //give it a label
 : row  {
 : radio_button {    //define radion button
        key = "rb1" ;     //give it a name
        label = "Apply to Current Layout ONLY" ; //give it a label
        value = "1" ;     //switch it on
          }
 : radio_button {    //define radion button
         key = "rb2" ;    //give it a name
         label = "Apply to All Layouts" ; //give it a label
          }  
 }
}




: boxed_column {      
label = "Revision Data" ;    //give it a label
 : row  {
        	: column {
         		: text {label = "Lines"; }
		: radio_button { key = "rbl9" ;label = "Line 9" ; }
		: radio_button { key = "rbl8" ;label = "Line 8" ; }
		: radio_button { key = "rbl7" ;label = "Line 7" ; }
		: radio_button { key = "rbl6" ;label = "Line 6" ; }
		: radio_button { key = "rbl5" ;label = "Line 5" ; }
		: radio_button { key = "rbl4" ;label = "Line 4" ; }
		: radio_button { key = "rbl3" ;label = "Line 3" ; }
		: radio_button { key = "rbl2" ;label = "Line 2" ; }
		: radio_button { key = "rbl1" ;label = "Line 1" ;value = "1" ; }
       	 }
 	: column  {
  		: text {label = "Rev"; alignment = centered;} 
  		: ed1  { key = "L9-Rev"; }
  		: ed1  { key = "L8-Rev"; }
          		: ed1  { key = "L7-Rev"; }
          		: ed1  { key = "L6-Rev"; }
          		: ed1  { key = "L5-Rev"; }
         		: ed1  { key = "L4-Rev"; }
          		: ed1  { key = "L3-Rev"; }
          		: ed1  { key = "L2-Rev"; }
          		: ed1  { key = "L1-Rev"; }
	}
 	: column  {
  		: text {label = "By"; alignment = centered;}
  		: ed2  { key = "L9-By" ; }
         		: ed2  { key = "L8-By" ; }
         		: ed2  { key = "L7-By" ; }
         		: ed2  { key = "L6-By" ; }
         		: ed2  { key = "L5-By" ; }
         		: ed2  { key = "L4-By" ; }
  		: ed2  { key = "L3-By" ; }
         		: ed2  { key = "L2-By" ; }
         		: ed2  { key = "L1-By" ; }         
        	}
        	: column {
         		: text {label = "Date"; alignment = centered;}
  		: ed3  { key = "L9-Date";  }
          		: ed3  { key = "L8-Date";  }
          		: ed3  { key = "L7-Date";  }
          		: ed3  { key = "L6-Date";  }
          		: ed3  { key = "L5-Date";  }
          		: ed3  { key = "L4-Date";  }
          		: ed3  { key = "L3-Date";  }
          		: ed3  { key = "L2-Date";  }
          		: ed3  { key = "L1-Date";  }
        	}
        	: column {
         		: text {label = "Description"; }
  		: ed4  { key = "L9-Description"; }
          		: ed4  { key = "L8-Description"; }
          		: ed4  { key = "L7-Description"; }
          		: ed4  { key = "L6-Description"; }
          		: ed4  { key = "L5-Description"; }
          		: ed4  { key = "L4-Description"; }
          		: ed4  { key = "L3-Description"; }
          		: ed4  { key = "L2-Description"; }
          		: ed4  { key = "L1-Description"; }
       	}
        	}
        spacer ;
 }
              : row  {
   ok_cancel ;    //predifined OK/Cancel
      }
   }

[pBe]

Woodman78, I'm using ACAD2009 and cant open your DB. I tried DWGTrueview but the dynamic properties disappears whenever i convert a file.

[woodman78]

Try this pBe.

rev-box.dwg

EDIT: I saved it in 2007 format.

[pBe]

Try this pBe.
Attachment 34519
EDIT: I saved it in 2007 format.

Thats very nice of you to do that woodman78, I've have a look-see. keep you posted.

EDIT: i had a look at your code. Question for you, how often does a drawing contains varying rev number from one layout to another?
Is MODEL SPACE count as layout"?
Whats the deal with the radio_buttons (line 1, Line 2....) whats suppose to happen if you if you click one other than Line 1?

[woodman78]

Thanks pBe. Firstly the model tab does not count. We never have a title block in the model tab.
Next, the radio buttons were an attempt to control the visibility state of the dynamic block. I was going to get the person to manually select which line to show. That was why I was using LeeMac's sub routines.
Lastly, after testing different ways of storing our drawing files we settled on what follows:

1. A drawing is created that may have a few layouts. The layouts are used to cover the length of a project which could be a few kilometers long.
2. Say for example the drawing would then have the name
L2472-LA-01,02,03_A0
(L2472 is the project code, LA represents the drawing type - Layout Plan, 01,02,03 are the drawing number and the A0 is the revision.)
it may happen that one of those drawings needs to be altered and reved up. What we do in that case is that we make a copy of the original drawing, make the changes and save it as say L2472-LA-01_A0,02_A1,03_A0. In this case 02 would have been revved up to A1 and the other two left alone. We found this to be the best way of controlling the drawings so that we would not split the set and risk that someone would bypass the latest version.

This does happen quite often.

If you or anyopne suggests a better way of doing this then please let me know and I will look at it.

Hope this helps pBe and thanks for your time and your help.

[pBe]

Okay here's hafl of the idea Woodman78, [Up to the point where i scratch my head and wondering what the radio buttons are for]
Redefine your DBlock and remove all Default values.
Re-write the way the program select the DBlocks
For now I grayed out Apply to All Layout [as of this time]
The code to include the ff LM routines [You know where to find this] http://www.lee-mac.com/dynamicblockfunctions.html
LM:GetVisibilityState
LM:SetVisibilityState
LM:GetVisibilityParameterName
and pBe's [included in the post]
_AttFunc
_PutValtoVar
_AssignVal
_ReduceList

Lisp Code

(defun c:attab12 ( / bn Adoc Layt BlkColl RevList)
(setq bn "rev-box" Visname "Visibility1")
(setq aDoc (vla-get-ActiveDocument (vlax-get-acad-object))
      Layt (vla-get-layouts aDoc))
      (setq BlkColl nil lytn  (vla-get-name (vla-get-ActiveLayout aDoc)))
      (if (foreach layoutname (layoutlist)
  (vlax-for itm (vlax-get (vla-item Layt layoutname) 'Block)
                 (if (and
                           (eq (vla-get-ObjectName itm) "AcDbBlockReference")
                           (vlax-property-available-p itm 'effectivename)
                    (eq (vla-get-EffectiveName itm) bn)
                    (eq (LM:GetVisibilityParameterName itm) Visname)
                   )
                      (setq BlkColl
                                    (cons (list layoutname
                                                (LM:GetVisibilityState
                                                      itm)
                                                itm)
                                          BlkColl)))))
          (ddisplay lytn BlkColl)
  )
      ) 
 
(defun ddisplay (clay  lst / dcl_id RevList ByList DateList DescList
                 DescList RButtons ATTData NewVal VisState RunHere)      
(setq RevList '("L1-REV" "L2-REV" "L3-REV" "L4-REV" "L5-REV"
                      "L6-REV" "L7-REV" "L8-REV" "L9-REV")
      ByList  '("L1-BY" "L2-BY" "L3-BY" "L4-BY" "L5-BY" "L6-BY"
                      "L7-BY" "L8-BY" "L9-BY")
      DateList '("L1-DATE" "L2-DATE" "L3-DATE" "L4-DATE" "L5-DATE"
                     "L6-DATE" "L7-DATE" "L8-DATE" "L9-DATE")
      DescList '("L1-DESCRIPTION" "L2-DESCRIPTION" "L3-DESCRIPTION" "L4-DESCRIPTION"
                 "L5-DESCRIPTION" "L6-DESCRIPTION" "L7-DESCRIPTION" "L8-DESCRIPTION"
                 "L9-DESCRIPTION")
      RButtons '("rbl1" "rbl2" "rbl3" "rbl4" "rbl5" "rbl6" "rbl7" "rbl8" "rbl9"))
(setq ATTData (_AttFunc (last (setq CRevB (assoc clay lst))) nil))
(setq dcl_id (load_dialog "attab.dcl"))
 (if (not (new_dialog "attab12" dcl_id))
     (exit))
      (set_tile (if (null rbd) "rbl1" (strcat "rbl" rbd)) "1")
  (_AssignVal RevList (_ReduceList "REV" ATTData))
        (_AssignVal ByList  (_REDUCELIST "BY" ATTData))
        (_AssignVal DateList (_REDUCELIST "DATE" ATTData))
        (_AssignVal DescList (_REDUCELIST "DESCRIPTION" ATTData))
 (action_tile "accept" "(setq NewVal (_PutValtoVar (mapcar 'car ATTData)))
          (setq VisState (_PutValtoVar RButtons))
          (setq RunHere (get_tile \"rb1\"))
                    (done_dialog 1)")
   (action_tile "cancel" "(done_dialog 0)") 
 (start_dialog)
   (unload_dialog dcl_id)
 (if (and NewVal VisState)
            (progn
             (foreach Blk (if (eq RunHere "1")  (list CRevB) lst)
                    ( _AttFunc (last Blk) NewVal)
                (LM:SetVisibilityState (last Blk)
                (strcat "Line" (setq rbd  (itoa (1+ (vl-position "1" (mapcar 'cadr VisState))))))
                )))
            )
      )

(defun _ReduceList (str lst)
      (vl-remove-if-not  '(lambda (ly)(wcmatch (car ly) (strcat "*" str)) ) lst))
(defun _AssignVal (lst1 lst2)                 
 (mapcar '(lambda (d1 d2)
   (set_tile d1 (cadr d2))) lst1 lst2))
(defun _PutValtoVar (lst_)
(mapcar '(lambda (vr)
               (list vr (set (read vr) (get_tile vr))))
                lst_)
    )
(defun _AttFunc  (en lst / vals v)
(mapcar (function (lambda (at)
 (setq vals (list (vla-get-tagstring at)(vla-get-textstring at)))
           (if (and lst (setq v (assoc (car vals) lst)))
                   (vla-put-textstring at (cadr v))) vals))
                      (vlax-invoke (if (eq (type en) 'VLA-OBJECT)
                                  en (vlax-ename->vla-object en)) 'Getattributes)
   )
  )

REMINDER:
The Only thing I changed on the DCL is capitalize all key values except those "rbl1" "rbl2"...... and "br1" "br2" "accept" cancel"

Try it. HTH

rev-box.dwg <---- modified Dynamic Block

CODE UPDATED

[asos2000]

I seached for this lisp on afralisp but not found
So Could you please upload the lisp with DCL?

[pBe]

I seached for this lisp on afralisp but not found
So Could you please upload the lisp with DCL?

^ <----- You can find the DCL codes on this thread. posted by Woodman78
||
||
|| < --- -- UP there asos2000 =======>>> Next Page [Post #42] ======>>

[woodman78]

pBe, when I run the lisp with your version of the block the dialog loads and I can enter information but when I press ok I get the following error:

; error: ActiveX Server returned an error: Parameter not optional