ELECTRICAL LISP WIRING

[MOHAMMED AHMED SD]

Can any one help me to find this error of lisp used to draw wire. 

 

When i drag drop it in autocad give me error:(maleformed list in INPUT) 

 

Am upload file below 

wiredraw.lsp

[Tharwat]

Here is my wiring program, the trial version is old now but the latest one is more advanced.

https://autolispprograms.wordpress.com/wiring-program/

[Steven P]

Nearly there, a couple of small errors, see below. I added a couple of descriptions into the code, lined things up a little to make them easier for me to read if that is OK?

 

malformd list in input is where brackets don't match or line up right - you might have them all in, but not necessarily in the right places - simple internet search will tell you that i think - trick is working out where....

 

EDITTED THE CODE BELOW SLIGHTLY

 

;; Draw Electric Wire
(defun c:ew ( / ew_layer p1 p2 msg ) 
  (setq ew_layer "Wire") 

  (defun draw-ew ( p4 p1 lay / p2 p3 ) 
;;I'VE SPLIT THESE SETQ P2 and P3 into 2, TO MAKE YOUR DEBUGGING EASIER... THERE IS AN ERROR HERE
;;(polar pt ang dist)....
    (setq p2 (polar p1 (- (angle p1 p4) (/ pi ) 57.40259411) ))
    (setq p3 (polar p4 (+ (angle p4 p1) (/ pi ) 57.40259411) ))

;;YOU WANT SOMETHING LIKE THIS?
;;    (setq dist 5)
;;    (setq p2 (polar p1 (- (angle p1 p4) (/ pi 57.40259411)) dist ))
;;    (setq p3 (polar p4 (+ (angle p4 p1) (/ pi 57.40259411)) dist ))

    (entmakex 
      (list
        '(0 . "LWPOLYLINE") '(100 . "AcDbEntity") '(100 . "AcDbPolyline") 
        (cons 8 lay) (cons 90 4) '(70 . 0)
        (cons 10 p1) '(40 . 0.0) '(41 . 0.0) '(42 . 0.198912) 
        (cons 10 p2) '(40 . 0.0) '(41 . 0.0) '(42 . 0.0) 
        (cons 10 p3) '(40 . 0.0) '(41 . 0.0) '(42 . 0.198913) 
        (cons 10 p4) '(40 . 0.0) '(41 . 0.0) '(42 . 0.0) 
      ) ; end list
    )  ; end entmakex
  ) ; end defun

  (setq p1 (getpoint "\nPick start point (Draw clockwise"))
  (setq msg "\nPick next point clockwise.")
  (while (setq p2 (getpoint p1 msg))
    (draw-ew p1 p2 ew_layer)
    (setq p1 p2) 
  )

  (princ) 
)
(prompt "\nElectric Wire loaded, Enter EW to run.")

 

Edited July 5, 2023 by Steven P