mhy3sx Posted Tuesday at 04:07 PM Posted Tuesday at 04:07 PM Hi I am writting a lisp to draw 2d stair. The idea is to select the fist step --> move it to layer STAIR then pick two points for the length of the stair and give the number of the steps. Then the code draw the stair with direction arrow in the middle. The code work perfect if i select the two points only from the one side of the stair. Is not all the time the left or the right side depends of the rotation. Can any one help me to update the code to work for bouth sides and don't misalign the steps. Here is the code . By the way i use ZWCAD. (defun c:Stair2D (/ p1 p2 ent ent_data step_start step_end step_vec stair_vec num_steps i base_pt new_p1 new_p2 mid1 mid2 last_base last_p1 last_p2 arrow_p1 arrow_p2 arrow_p3) (vl-load-com) (setvar "CMDECHO" 0) (command "._UNDO" "_BEGIN") (if (not (tblsearch "LAYER" "STAIR")) (command "_layer" "_m" "STAIR" "_c" "90" "" "") ) (setvar "CLAYER" "STAIR") (princ "\nSelect the first step of the staircase: ") (while (not (setq ent (ssget ":S" '((0 . "LINE"))))) (princ "\nTry again!! ") ) (command "._CHANGE" ent "" "_P" "_LA" "STAIR" "") (setq ent_data (entget (ssname ent 0))) (setq step_start (cdr (assoc 10 ent_data))) (setq step_end (cdr (assoc 11 ent_data))) (setq step_vec (mapcar '- step_end step_start)) (setvar "OSMODE" 1) (setq p1 (getpoint "\nSelect the start of the staircase: ")) (setq p2 (getpoint p1 "\nSelect the end of the staircase: ")) (setvar "OSMODE" 0) (initget 7) (setq num_steps (getint "\nEnter the number of steps: ")) (setq stair_vec (mapcar '(lambda (a b) (/ (- b a) num_steps)) p1 p2)) (setq i 1) (while (<= i num_steps) (setq base_pt (mapcar '+ p1 (mapcar '(lambda (x) (* x i)) stair_vec))) (setq new_p1 base_pt) (setq new_p2 (mapcar '+ base_pt step_vec)) (command "._LINE" new_p1 new_p2 "") (setq i (1+ i)) ) (setq mid1 (mapcar '(lambda (a b) (/ (+ a b) 2.0)) step_start step_end)) (setq last_base (mapcar '+ p1 (mapcar '(lambda (x) (* x num_steps)) stair_vec))) (setq last_p1 last_base) (setq last_p2 (mapcar '+ last_base step_vec)) (setq mid2 (mapcar '(lambda (a b) (/ (+ a b) 2.0)) last_p1 last_p2)) (command "._line" mid1 mid2 "" "" "_N") (command "._CIRCLE" mid1 0.06) (setq mid1mid2_vec (mapcar '- mid2 mid1)) (setq mid1mid2_length (distance mid1 mid2)) (setq unit_vec (mapcar '(lambda (x) (/ x mid1mid2_length)) mid1mid2_vec)) (setq perp_vec (list (- (cadr unit_vec)) (car unit_vec) 0.0)) (setq arrow_p1 (mapcar '+ mid2 (mapcar '(lambda (x) (* x 0.10)) unit_vec))) (setq arrow_p2 (mapcar '+ mid2 (mapcar '(lambda (x) (* x -0.15)) perp_vec))) (setq arrow_p3 (mapcar '+ mid2 (mapcar '(lambda (x) (* x 0.15)) perp_vec))) (command "._LINE" arrow_p1 arrow_p2 "") (command "._LINE" arrow_p1 arrow_p3 "") (command "._UNDO" "_END") (setvar "CMDECHO" 1) (setvar "CLAYER" "0") (princ) ) Thanks Drawing2.dwg Quote
DATVO Posted yesterday at 08:10 AM Posted yesterday at 08:10 AM (edited) 16 hours ago, mhy3sx said: Hi I am writting a lisp to draw 2d stair. The idea is to select the fist step --> move it to layer STAIR then pick two points for the length of the stair and give the number of the steps. Then the code draw the stair with direction arrow in the middle. The code work perfect if i select the two points only from the one side of the stair. Is not all the time the left or the right side depends of the rotation. Can any one help me to update the code to work for bouth sides and don't misalign the steps. Here is the code . By the way i use ZWCAD. Does this match your expectations? Edited yesterday at 08:24 AM by DATVO 2 Quote
mhy3sx Posted 20 hours ago Author Posted 20 hours ago (edited) Hi DATVO. Yes , I update my code to work only for the left side every time.How you do it? Can you post the code? Thanks Edited 16 hours ago by mhy3sx Quote
DATVO Posted 8 hours ago Posted 8 hours ago Here is the code @mhy3sx, based on your original file. I've modified a few lines using a different approach, but the result remains the same. If you find this helpful, feel free to visit my page where I share tools designed to improve efficiency and save time, as effortlessly as enjoying a cup of coffee: https://lispautocad.gumroad.com/ ;; Modified by DV. Visit my page at: https://lispautocad.gumroad.com/ (defun c:Stair2D (/ p1 p2 ent start_pt end_pt mid_pt line_length circle_diameter num_steps i move_vec array_vec step_vec last_start_pt last_end_pt last_mid_pt mid1mid2_vec mid1mid2_length unit_vec perp_vec arrow_p1 arrow_p2 arrow_p3) (vl-load-com) (setvar "CMDECHO" 0) (command "._UNDO" "_BEGIN") (if (not (tblsearch "LAYER" "STAIR")) (command "_layer" "_m" "STAIR" "_c" "90" "" "") ) (setvar "CLAYER" "STAIR") (princ "\nSelect the first LINE of the staircase: ") (while (not (setq ent (ssget ":S" '((0 . "LINE"))))) (princ "\nTry again!! ") ) (command "._CHANGE" ent "" "_P" "_LA" "STAIR" "") (setq ent (ssname ent 0)) (setq ent_data (entget ent)) (setq start_pt (cdr (assoc 10 ent_data))) (setq end_pt (cdr (assoc 11 ent_data))) (setq mid_pt (mapcar '(lambda (a b) (/ (+ a b) 2.0)) start_pt end_pt)) (setq line_length (distance start_pt end_pt)) (setq circle_diameter (/ line_length 10.0)) (princ "\nSelect the start of the staircase: ") (setq p1 (getpoint)) (princ "\nSelect the end of the staircase: ") (setq p2 (getpoint p1)) (initget 7) (setq num_steps (getint "\nEnter the number of steps: ")) (setq array_vec (mapcar '- p2 p1)) (setq step_vec (mapcar '(lambda (x) (/ x num_steps)) array_vec)) (setq i 1) (while (<= i num_steps) (setq move_vec (mapcar '(lambda (x) (* x i)) step_vec)) (command "._COPY" ent "" "_non" (list 0 0 0) "_non" move_vec) (setq i (1+ i)) ) ;; Circle and arrow line (command "._CIRCLE" mid_pt (/ circle_diameter 2.0)) (setq last_start_pt (mapcar '+ start_pt (mapcar '(lambda (x) (* x num_steps)) step_vec))) (setq last_end_pt (mapcar '+ end_pt (mapcar '(lambda (x) (* x num_steps)) step_vec))) (setq last_mid_pt (mapcar '(lambda (a b) (/ (+ a b) 2.0)) last_start_pt last_end_pt)) (command "._LINE" mid_pt last_mid_pt "") (setq mid1mid2_vec (mapcar '- last_mid_pt mid_pt)) (setq mid1mid2_length (distance mid_pt last_mid_pt)) (if (> mid1mid2_length 0) (progn (setq unit_vec (mapcar '(lambda (x) (/ x mid1mid2_length)) mid1mid2_vec)) (setq perp_vec (list (- (cadr unit_vec)) (car unit_vec) 0.0)) (setq arrow_p1 (mapcar '+ last_mid_pt (mapcar '(lambda (x) (* x 0.10 mid1mid2_length)) unit_vec))) (setq arrow_p2 (mapcar '+ last_mid_pt (mapcar '(lambda (x) (* x -0.15 mid1mid2_length)) perp_vec))) (setq arrow_p3 (mapcar '+ last_mid_pt (mapcar '(lambda (x) (* x 0.15 mid1mid2_length)) perp_vec))) (command "._LINE" arrow_p1 arrow_p2 "") (command "._LINE" arrow_p1 arrow_p3 "") ) ) (command "._UNDO" "_END") (setvar "CMDECHO" 1) (setvar "CLAYER" "0") (princ) ) Quote
Saxlle Posted 1 hour ago Posted 1 hour ago @mhy3sx I made the same command (I hope the ZWCAD have the same functions as AutoCAD), but with the less line code and a different approach. It works the same as @DATVO modified your code, the result is the same. ; ******************************************************** ; Functions : stair2D ; Description : Drawing 2D stairs between two LINE ; Author : SAXLLE ; Date : August 07, 2025 ; ******************************************************** (prompt "\nTo run a LISP type: stair2D") (princ) (defun c:stair2D ( / old_osmode old_aunits old_layer flag ent pt1 pt2 pt3 dist num_steps equal_offset half_dist ang new_ang circle_radius off npt midptdel midptbase val midpt1 midpt2 midpt3 answ) (setq old_osmode (getvar 'osmode) old_aunits (getvar 'aunits) old_layer (getvar 'clayer) ) (setvar 'aunits 0) (setq flag T) (while (not (equal flag nil)) (setvar 'osmode 1) (setq ent (car (entsel "\nSelecte the BASE line:\n"))) (while (or (equal ent nil) (not (equal (cdr (assoc 0 (entget ent))) "LINE"))) (prompt "Try again...") (princ) (setq ent (car (entsel "\nSelecte the BASE line:\n"))) ) (setq pt1 (getpoint "\nPick the first point of the BASE line:\n") pt2 (getpoint pt1 "\nPick the second point of the BASE line:\n") pt3 (getpoint pt1 "\nGet the distance between BASE line and PARALLEL line:\n") dist (distance pt1 pt3) num_steps (getint "\nEnter the number of STEPS:") equal_offset (/ (getpropertyvalue ent "Length") num_steps) half_dist (/ dist 2) ang (angle pt1 pt2) new_ang (angle pt1 pt3) circle_radius 0.06 off 0.0 npt (list) ) (setvar 'osmode 0) (if (not (tblsearch "LAYER" "STAIR")) (command "_-layer" "_m" "STAIR" "_c" "90" "" "") (setvar 'clayer "STAIR") ) (command-s "_UNDO" "begin") (setq midptdel (mapcar '* (mapcar '+ pt1 pt3) '(0.5 0.5))) (command-s "_ERASE" midptdel "") (command-s "_LINE" pt1 (strcat "@" (rtos dist 2 2) "<" (angtos new_ang)) "") (setq midptbase (mapcar '* (mapcar '+ (getpropertyvalue (entlast) "StartPoint") (getpropertyvalue (entlast) "EndPoint")) '(0.5 0.5))) (command-s "_CIRCLE" midptbase circle_radius "") (repeat num_steps (setq val (vlax-curve-getPointAtDist (vlax-ename->vla-object ent) off) npt (append npt (list val)) off (+ off equal_offset) ) ) (setq npt (reverse npt)) (foreach pt npt (command-s "_LINE" pt (strcat "@" (rtos dist 2 2) "<" (angtos new_ang)) "") ) (setq midpt (mapcar '* (mapcar '+ (getpropertyvalue (entlast) "StartPoint") (getpropertyvalue (entlast) "EndPoint")) '(0.5 0.5)) midpt1 (mapcar '* (mapcar '+ (getpropertyvalue (entlast) "StartPoint") midpt) '(0.5 0.5)) midpt2 (mapcar '* (mapcar '+ (getpropertyvalue (entlast) "EndPoint") midpt) '(0.5 0.5)) midpt3 (polar midpt ang (/ half_dist 2)) ) (command-s "_LINE" midptbase (strcat "@" (rtos (getpropertyvalue ent "Length") 2 2) "<" (angtos ang)) "") (command-s "_LINE" midpt1 midpt3 midpt2 "") (command-s "_UNDO" "end") (initget 1 "Yes No Undo") (setq answ (getkword "\Do you want to continue? [Yes/No/Undo]")) (cond ((equal answ "No") (setq flag nil) ) ((equal answ "Undo") (command-s "_UNDO" "") ) ) (setvar 'osmode 1) ) (command-s "_regen") (setvar 'osmode old_osmode) (setvar 'aunits old_aunits) (setvar 'clayer old_layer) (prompt "\nThe 2D stairs are drawn!") (princ) ) This is the example video. STAIR2D.mp4 Best regards. Quote
mhy3sx Posted 41 minutes ago Author Posted 41 minutes ago Thanks for the help DATVO and Saxlle. Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.